discordjs / discord.js-modules

Modularisation of discord.js (WIP)
Apache License 2.0
192 stars 30 forks source link

feat(RateLimits): optionally error on ratelimits #77

Closed ckohen closed 2 years ago

ckohen commented 3 years ago

Please describe the changes this PR makes and why it should be merged:

Ported from https://github.com/discordjs/discord.js/pull/5659

Needs #51

Status and versioning classification:

codecov[bot] commented 3 years ago

Codecov Report

Merging #77 (c190f00) into main (46c9183) will increase coverage by 0.02%. The diff coverage is 89.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   88.83%   88.86%   +0.02%     
==========================================
  Files           8        9       +1     
  Lines        1344     1455     +111     
  Branches      142      152      +10     
==========================================
+ Hits         1194     1293      +99     
- Misses          9       12       +3     
- Partials      141      150       +9     
Impacted Files Coverage Δ
...ackages/rest/src/lib/handlers/SequentialHandler.ts 82.44% <80.00%> (-0.48%) :arrow_down:
packages/rest/src/lib/errors/RateLimitError.ts 93.33% <93.33%> (ø)
packages/rest/src/lib/REST.ts 96.46% <100.00%> (+0.28%) :arrow_up:
packages/rest/src/lib/RequestManager.ts 94.20% <100.00%> (+0.31%) :arrow_up:
packages/rest/src/lib/utils/constants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 46c9183...c190f00. Read the comment docs.

ckohen commented 3 years ago

Not really sure why CI is failing (cache is set to npm when we're using yarn though, so maybe that's it?)

iCrawl commented 3 years ago

That might just be my fault, yes 😆 Will fix and then request a rebase.