TypeError in GuildDeleteAction.handle when Destroying Voice Adapter

prineec commented 3 months ago

Which package is this bug report for?

discord.js

Issue description

When handling the 'guildDelete' event in a Discord bot using Discord.js, a TypeError occurs in the GuildDeleteAction.handle method. The error arises when attempting to destroy the voice adapter associated with the guild. This happens because the client.voice.adapters object is either undefined or lacks the get method.

path: F:\xyz\node_modules\discord.js\src\client\actions\GuildDelete.js

Error Stack:

TypeError: Cannot read properties of undefined (reading 'get')
    at GuildDeleteAction.handle (/home/ubuntu/node_modules/discord.js/src/client/actions/GuildDelete.js:29:29)
    at module.exports [as GUILD_DELETE] (/home/ubuntu/node_modules/discord.js/src/client/websocket/handlers/GUILD_DELETE.js:4:30)
    at WebSocketManager.handlePacket (/home/ubuntu/node_modules/discord.js/src/client/websocket/WebSocketManager.js:353:31)
    at WebSocketManager.<anonymous> (/home/ubuntu/node_modules/discord.js/src/client/websocket/WebSocketManager.js:237:12)
    at WebSocketManager.emit (/home/ubuntu/node_modules/@vladfrangu/async_event_emitter/dist/index.cjs:282:31)
    at WebSocketShard.<anonymous> (/home/ubuntu/node_modules/@discordjs/ws/dist/index.js:1103:51)
    at WebSocketShard.emit (/home/ubuntu/node_modules/@vladfrangu/async_event_emitter/dist/index.cjs:282:31)
    at WebSocketShard.onMessage (/home/ubuntu/node_modules/@discordjs/ws/dist/index.js:938:14)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

basically you guys missed a ?. in very short Skill Issue.

Code sample

'use strict';

const Action = require('./Action');
const Events = require('../../util/Events');

class GuildDeleteAction extends Action {
  handle(data) {
    const client = this.client;

    let guild = client.guilds.cache.get(data.id);
    if (guild) {
      if (data.unavailable) {
        // Guild is unavailable
        guild.available = false;

        /**
         * Emitted whenever a guild becomes unavailable, likely due to a server outage.
         * @event Client#guildUnavailable
         * @param {Guild} guild The guild that has become unavailable
         */
        client.emit(Events.GuildUnavailable, guild);

        // Stops the GuildDelete packet thinking a guild was actually deleted,
        // handles emitting of event itself
        return;
      }

      for (const channel of guild.channels.cache.values()) this.client.channels._remove(channel.id);

      // Destroy the voice adapter associated with the guild if it exists
      client.voice.adapters?.get(data.id)?.destroy();

      // Delete guild
      client.guilds.cache.delete(guild.id);

      /**
       * Emitted whenever a guild kicks the client or the guild is deleted/left.
       * @event Client#guildDelete
       * @param {Guild} guild The guild that was deleted
       */
      client.emit(Events.GuildDelete, guild);
    }
  }
}

module.exports = GuildDeleteAction;

Versions

discord.js above v14.12.0, node.js version: v20.13.1, windows 11

Issue priority

Medium (should be fixed soon)

Which partials do you have configured?

No Partials

Which gateway intents are you subscribing to?

Guilds

I have tested this issue on a development release

No response

Jiralite commented 3 months ago

I do not see how this is possible. It is instantiated with the property:

https://github.com/discordjs/discord.js/blob/a468ae8bb5a9de9cb34d40493c59693e84c2812a/packages/discord.js/src/client/Client.js#L99

ClientVoiceManager is also instantiated with the property:

https://github.com/discordjs/discord.js/blob/a468ae8bb5a9de9cb34d40493c59693e84c2812a/packages/discord.js/src/client/voice/ClientVoiceManager.js#L22

We should have a lot of reports regarding this since 14.12.0 (the version you claim), but there are none.

Are you modifying internal behaviour? Can you share a reproducible sample?