discordjs / discord.js

A powerful JavaScript library for interacting with the Discord API
https://discord.js.org
Apache License 2.0
25.44k stars 3.97k forks source link

feat(InteractionResponses): support with_response query parameter #10499

Open monbrey opened 2 months ago

monbrey commented 2 months ago

Please describe the changes this PR makes and why it should be merged: Closes #10498

/core done in #10512

Upstream: https://github.com/discord/discord-api-docs/pull/7106

Status and versioning classification:

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **discord-js** | ⬜️ Ignored ([Inspect](https://vercel.com/discordjs/discord-js/EnZHPZXkCW9EvK8z2QuDJLy94EcE)) | [Visit Preview](https://discord-js-git-fork-monbrey-withresponse-discordjs.vercel.app) | | Nov 17, 2024 7:21pm | | **discord-js-guide** | ⬜️ Ignored ([Inspect](https://vercel.com/discordjs/discord-js-guide/2WWkcMKebhvDAZv3hXrdzBvEPBsW)) | [Visit Preview](https://discord-js-guide-git-fork-monbrey-withresponse-discordjs.vercel.app) | | Nov 17, 2024 7:21pm |
Jiralite commented 2 months ago

This also required a discord-api-types version bump

We'll wait for #10488 before this one lands.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.49%. Comparing base (cda8d88) to head (8b69bd4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10499 +/- ## ========================================== + Coverage 35.48% 35.49% +0.01% ========================================== Files 228 228 Lines 14308 14303 -5 Branches 1254 1254 ========================================== Hits 5077 5077 + Misses 9187 9182 -5 Partials 44 44 ``` | [Flag](https://app.codecov.io/gh/discordjs/discord.js/pull/10499/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=discordjs) | Coverage Δ | | |---|---|---| | [guide](https://app.codecov.io/gh/discordjs/discord.js/pull/10499/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=discordjs) | `0.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=discordjs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jiralite commented 1 month ago

Please resolve conflicts!