discordjs / discord.js

A powerful JavaScript library for interacting with the Discord API
https://discord.js.org
Apache License 2.0
25.44k stars 3.97k forks source link

chore: make semver:major block kodiak #10548

Closed vladfrangu closed 1 month ago

vladfrangu commented 1 month ago

Please describe the changes this PR makes and why it should be merged:

This is realistically a proposal and can be closed if we don't do it, but as we tend to want to merge major PRs manually (to ensure the commit has changelog entry correct), I think we should skip adding in an extra label.

Status and versioning classification:

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **discord-js** | ⬜️ Ignored ([Inspect](https://vercel.com/discordjs/discord-js/7rqkbBRiNYSvPMkDYuymp3UNz5of)) | [Visit Preview](https://discord-js-git-vlad-mark-semver-major-as-blocking-discordjs.vercel.app) | | Oct 16, 2024 0:31am | | **discord-js-guide** | ⬜️ Ignored ([Inspect](https://vercel.com/discordjs/discord-js-guide/4N25XPVXFHvn5PAKFhr3Ue82ye5p)) | [Visit Preview](https://discord-js-guide-git-vlad-mark-semver-major-as-5bc05b-discordjs.vercel.app) | | Oct 16, 2024 0:31am |
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.03%. Comparing base (24128a3) to head (29b994b). Report is 13 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10548 +/- ## ========================================== + Coverage 38.00% 38.03% +0.02% ========================================== Files 239 239 Lines 15488 15464 -24 Branches 1367 1353 -14 ========================================== - Hits 5886 5881 -5 + Misses 9587 9568 -19 Partials 15 15 ``` | [Flag](https://app.codecov.io/gh/discordjs/discord.js/pull/10548/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=discordjs) | Coverage Δ | | |---|---|---| | [builders](https://app.codecov.io/gh/discordjs/discord.js/pull/10548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=discordjs) | `82.43% <ø> (+0.77%)` | :arrow_up: | | [proxy](https://app.codecov.io/gh/discordjs/discord.js/pull/10548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=discordjs) | `66.27% <ø> (ø)` | | | [rest](https://app.codecov.io/gh/discordjs/discord.js/pull/10548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=discordjs) | `87.37% <ø> (ø)` | | | [util](https://app.codecov.io/gh/discordjs/discord.js/pull/10548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=discordjs) | `41.42% <ø> (ø)` | | | [voice](https://app.codecov.io/gh/discordjs/discord.js/pull/10548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=discordjs) | `72.23% <ø> (ø)` | | | [ws](https://app.codecov.io/gh/discordjs/discord.js/pull/10548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=discordjs) | `36.21% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=discordjs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.