Update ffmpeg-binaries to ffmpeg or ffmpeg-static

discordjs / discord.js

A powerful JavaScript library for interacting with the Discord API

https://discord.js.org

Apache License 2.0

25.47k stars 3.97k forks source link

Update ffmpeg-binaries to ffmpeg or ffmpeg-static #3391

Closed ao-quantum closed 5 years ago

ao-quantum commented 5 years ago

More of a Heroku hosting thing, ffmpeg-binaries is deprecated and doesn't work in Heroku. This is a problem with music bots as when they join the voice channel, they leave and declare the song has ended. The npm page suggests using ffmpeg or ffmpeg-static. However, ffmpeg-binaries does work elsewhere like windows

discord.js version: 11.5.1
Node.js version: LTS
Operating system: Unknown
Priority this issue should have – Low
[ ] I have also tested the issue on latest master, commit hash:

seia-soto commented 5 years ago

I think this need to be second option because of stability.

Already, there was many voice issues and many library method changes. I think adding ffmpeg as additional option to handle ffmpeg will be better.

amishshah commented 5 years ago

This isn't a bug, ffmpeg-binaries is deprecated and shouldn't be used at all, use ffmpeg-static as a replacement as advised.

ao-quantum commented 5 years ago

This isn't a bug, ffmpeg-binaries is deprecated and shouldn't be used at all, use ffmpeg-static as a replacement as advised.

I used it, it doesnt work

EBruchet commented 5 years ago

Hi @xXQuantumSoulXx, have you tried installing FFmpeg itself using your Heroku CLI?

ao-quantum commented 5 years ago

I've decided to not use ffmpeg, it was making things complicated and a music feature was unnecessary.

kedi commented 5 years ago

To make ffmpeg binaries work on Heroku, simply just create repistory with .gitignore as Node, it will just ignore whole node_modules. Move your code into that new repistory.

After that just recreate an application on Heroku and move your new repistory into that new application.

Problem shall be solved.