discordjs / opus

Native opus bindings for node
MIT License
192 stars 55 forks source link

Add Glibc 2.36 in the precompiled binaries #146

Open Theiremi opened 1 year ago

Theiremi commented 1 year ago

Is your feature request related to a problem? Please describe. I experience problems when i try to install this library on Ubuntu 22.10 because it needs to be compiled for glibc 2.36. The install process try to compile it on my computer but the compilation fail every time

Describe the ideal solution I though on adding a precompiled binary for glibc 2.36 so it simplifies the process of installing this lib on newer Ubuntu versions

Describe alternatives you've considered To make it work I'm currently modifying the line 49 of package.json file of the module from : "package_name": "{module_name}-v{version}-{node_abi}-napi-v{napi_build_version}-{platform}-{arch}-{libc}-{libc_version}.tar.gz", to : "package_name": "{module_name}-v{version}-{node_abi}-napi-v{napi_build_version}-{platform}-{arch}-{libc}-2.35.tar.gz", so it download the precompiled binary of glibc 2.35

JMTK commented 2 months ago

Just came here to +1 bump this

➤ YN0000: │ @discordjs/opus@npm:0.9.0 STDERR node-pre-gyp info check checked for "/app/node_modules/@discordjs/opus/prebuild/node-v120-napi-v3-linux-x64-glibc-2.36/opus.node" (not found)
➤ YN0000: │ @discordjs/opus@npm:0.9.0 STDERR node-pre-gyp http GET https://github.com/discordjs/opus/releases/download/v0.9.0/opus-v0.9.0-node-v120-napi-v3-linux-x64-glibc-2.36.tar.gz
➤ YN0000: │ @discordjs/opus@npm:0.9.0 STDERR node-pre-gyp ERR! install response status 404 Not Found on https://github.com/discordjs/opus/releases/download/v0.9.0/opus-v0.9.0-node-v120-napi-v3-linux-x64-glibc-2.36.tar.gz
➤ YN0000: │ @discordjs/opus@npm:0.9.0 STDERR node-pre-gyp WARN Pre-built binaries not installable for @discordjs/opus@0.9.0 and node@21.7.3 (node-v120 ABI, glibc) (falling back to source compile with node-gyp)
➤ YN0000: │ @discordjs/opus@npm:0.9.0 STDERR node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/discordjs/opus/releases/download/v0.9.0/opus-v0.9.0-node-v120-napi-v3-linux-x64-glibc-2.36.tar.gz

Would be super nice to skip this