discordjs / opus

Native opus bindings for node
MIT License
188 stars 53 forks source link

ci: fix build/release CI #148

Closed femshima closed 4 months ago

femshima commented 7 months ago

Please describe the changes this PR makes and why it should be merged:

ref: nodejs/node-gyp#2219 ref: nodejs/node-gyp#2869

This PR includes following changes:

Current workflow does not succeed due to updates to python 3.12 in github runners.

Fix python version to 3.8 in node <=17 and 19

Downgrading to python 3.8 is necessary in older node.js, because nodejs/node-gyp#2219 was fixed in gyp-next v0.7.0/node-gyp v0.8.0, which is not included in older node.js.

Remove macos-10.15 and ubuntu-18.04 runner

Also, macos-10.15 and ubuntu-18.04 runner job never starts, so I suggest removing them.

Add apt update before apt install

The Failed to fetch 404 not found error had occured because of this, and this PR also fixes that.

Add macos-13 runner Add node.js 20 and 21

Finally, I added macos-13 runner and node.js 20/21, because I think it is better to run test for these environment and provide prebuild. However, if you feel these should be in another PR and discussed separately, I am willing to remove them.

Semantic versioning classification: