discordjs / voice

Implementation of the Discord Voice API for discord.js and other JS/TS libraries
Apache License 2.0
328 stars 112 forks source link

refactor(Secretbox): type `methods` object #131

Closed kyranet closed 3 years ago

kyranet commented 3 years ago

Please describe the changes this PR makes and why it should be merged:

This PR types the methods object from Secretbox and removes an any cast, with the objective of improving the overall type safety in the library's internals.

Status and versioning classification:

codecov[bot] commented 3 years ago

Codecov Report

Merging #131 (c9f8079) into main (308b9b8) will not change coverage. The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   67.63%   67.63%           
=======================================
  Files          19       19           
  Lines         893      893           
  Branches      218      218           
=======================================
  Hits          604      604           
  Misses        287      287           
  Partials        2        2           
Impacted Files Coverage Δ
src/util/Secretbox.ts 57.89% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 308b9b8...c9f8079. Read the comment docs.