Adapter destroying voiceConnection when client reconnects

[MatteZ02]

Please describe the problem you are having in as much detail as possible: VoiceConnection changes state to destroyed from ready in the middle of playback. Sometimes this occurs after 10 minutes of listening, Sometimes after hours. Yet to find a proper way of reproducing this issue.

Include a reproducible code sample here, if possible:

    public async join(
        channel: Discord.VoiceChannel | Discord.StageChannel
    ): Promise<VoiceConnection | null> {
        try {
            this.voiceChannel = channel;
            const connection: VoiceConnection =
                getVoiceConnection(this.guild.id) ??
                joinVoiceChannel({
                    channelId: channel.id,
                    guildId: this.guild.id,
                    //@ts-ignore
                    adapterCreator: createDiscordJSAdapter(channel),
                    debug: this.client.config.debug.voiceConnection
                });
            this.connection = connection;
            this.connection
                .once("error", err => {
                    this.connection = null;
                    this.emit("error", err);
                })
                .on("stateChange", async (oldState, newState) => 
                    console.log(`oldStatus: ${oldState.status}, newStatus: ${newState.status}`)
                )
                .on("debug", console.log);
            return (
                (await entersState(connection, VoiceConnectionStatus.Ready, 15e3).catch(e => {
                    console.error(e);
                    if (connection.state.status !== "destroyed") connection.destroy();
                    if (this.exists) this._timeout();
                })) || null
            );
        } catch (error) {
            this.client.player.delete(channel.guild?.id as string);
            console.log("failed to obtain a voiceConnection");
            console.error(error);
            this.textChannel?.send(this.client.messages.error + error.toString());
            return null;
        }
    }

Further details:

• @discordjs/voice version: 0.5.4
• Node.js version: 14.15.0
• Operating system: Ubuntu 20.04 (also occurs on windows 10 with older versions of djs/voice)
• Priority this issue should have – please be realistic and elaborate if possible: medium to high. It really does mess with playback when occurring in the middle of playing.

Relevant client options:

• partials: none
• gateway intents: GUILDS, GUILD_VOICE_STATES, GUILD_MESSAGES
• other: none

[SpaceEEC]

Can you try getting a stacktrace in the statusUpdate event? Something like new Error().stack should do the trick.

[MatteZ02]

Will do. Might take up to a few days for me to catch the error again.

[MatteZ02]

Alright got the stack trace after 2 hours of continuous listening (on the same connection)

[amishshah]

Can you share your Player.js file?

[MatteZ02]

the uncompiled ts file of the player is 930 lines. I can send the entire thing if needed but is there any part you'd like to see in particular?

[MatteZ02]

Alright got the stack trace after 2 hours of continuous listening (on the same connection)

Unfortunately i didn't take a proper look at the chain of errors that occurred around this stack.

Anyhow i just ran into a different one. Seems like the ws shard closed which resulted in the voiceConnection being destroyed by the adapter.

Don't mind the different line numbers. This is a wip bot and the code is continuously changing (which at times makes debugging a mess)

[MatteZ02]

after 5 hours of debugging last night i got the error again. This time with debugging enabled for my djs client. so what happened was that the ws reconnected which caused the adapter to destroy the voiceConnection.

[MatteZ02]

Alright i got it. So the reason the voiceConnection is destroyed is due to the adapter function cleanupGuilds which will delete the existing voiceConnections. Just by commenting out adapters.get(guildID)?.destroy(); the problem went away.

[amishshah]

This is odd, the intended behaviour of the adapter provided by discord.js is to only destroy once the main WebSocket shard has disconnected and will not attempt to reconnect.

I will take a look at fixing this adapter.