Closed MatteZ02 closed 3 years ago
Merging #162 (eaea890) into main (516bc3b) will decrease coverage by
0.03%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #162 +/- ##
==========================================
- Coverage 68.65% 68.61% -0.04%
==========================================
Files 19 19
Lines 906 905 -1
Branches 221 221
==========================================
- Hits 622 621 -1
Misses 282 282
Partials 2 2
Impacted Files | Coverage Δ | |
---|---|---|
src/audio/AudioResource.ts | 96.66% <100.00%> (-0.06%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 516bc3b...eaea890. Read the comment docs.
Please describe the changes this PR makes and why it should be merged:
This pr replaces the
once(this.playStream, 'readable')
listener inside audioResouce with a properthis.playStream.once(...)
listener. Personally i experienced alot ofaudioPlayer failed to enter state playing in ????ms
errors prior to this fix. The timeout duration had no effect on this. I calculated that there was a 6 ms latency when usingonce(...)
compared tothis.playStream.once(...)
. During this 6 ms theaudioPlayer.play()
function executed missing the if statement forresouce.playing
and attaching the event listeners afteraudioResouce readable
event emitted.Status and versioning classification: