search

discordjs / voice

Implementation of the Discord Voice API for discord.js and other JS/TS libraries
Apache License 2.0
327 stars 111 forks source link

Support subscribing all users in `VoiceReceiver` #178

Closed rojvv closed 3 years ago

rojvv commented 3 years ago

Please describe the changes this PR makes and why it should be merged:

This PR lets the user to VoiceReceiver.subscribe('all') and it should be merged because it is lets subscribing all users.

amishshah commented 3 years ago

This is incorrect as you can't mix Opus packets from all users like this, they come from different encoder contexts.

If you want to subscribe to all users, you'll need to mux each stream into one, and that is out of the scope of this library as it is an audio processing concern.

rojvv commented 3 years ago

@amishshah Maybe you can add an example?