search

discordjs / voice

Implementation of the Discord Voice API for discord.js and other JS/TS libraries
Apache License 2.0
327 stars 111 forks source link

fix(esm): resolve esm imports #229

Closed samarmeena closed 2 years ago

samarmeena commented 2 years ago

Please describe the changes this PR makes and why it should be merged:

fixes #227

codecov[bot] commented 2 years ago

Codecov Report

Merging #229 (8718a12) into main (df656f8) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   73.65%   73.65%           
=======================================
  Files          21       21           
  Lines         911      911           
  Branches      227      227           
=======================================
  Hits          671      671           
  Misses        238      238           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update df656f8...8718a12. Read the comment docs.

samarmeena commented 2 years ago

Request for workflow approval, it is fixed now.

image

samarmeena commented 2 years ago

image

lib detected, hence issue will be fixed (tested). Just wait for final commit.

samarmeena commented 2 years ago

image

lib detected, hence issue will be fixed (tested). Just wait for final commit.

ready πŸ‘

iCrawl commented 2 years ago

Thanks!

I was about to do this myself but haven't had the time yet after I asked for the banner option to be added to tsup πŸ‘