search

discordjs / voice

Implementation of the Discord Voice API for discord.js and other JS/TS libraries
Apache License 2.0
328 stars 112 forks source link

Fix music bot example #237

Open conr opened 2 years ago

conr commented 2 years ago

Fixes for a bunch of Typescript errors in the music bot example.

almeidx commented 2 years ago

Should probably bump youtube-dl-exec to the latest version. And while you're at it, why not bump typescript to the latest version as well instead of 4.4?

conr commented 2 years ago

@almeidx Good call. Updated 👍🏻

conr commented 2 years ago

@iCrawl Is this good to go?

codecov[bot] commented 2 years ago

Codecov Report

Merging #237 (fb1aa78) into main (3dabc30) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   73.65%   73.65%           
=======================================
  Files          21       21           
  Lines         911      911           
  Branches      227      221    -6     
=======================================
  Hits          671      671           
  Misses        238      238           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3dabc30...fb1aa78. Read the comment docs.