search

discordx-ts / discordx

🤖 Create a discord bot with TypeScript and Decorators!
https://discordx.js.org
Apache License 2.0
614 stars 50 forks source link

refactor(plugin-lava-player): add lyrics plugin #1039

Closed guilhermehccruz closed 3 months ago

guilhermehccruz commented 3 months ago

Implements the integration with lavalink lyrics endpoint along with examples of how to use it

samarmeena commented 3 months ago

@guilhermehccruz hi, I wanted to see if you'd be available to discuss a few adjustments on our Discord server. It would be easier to communicate there. If that doesn't work for you, I can update your PR myself. Thanks!

guilhermehccruz commented 3 months ago

@guilhermehccruz hi, I wanted to see if you'd be available to discuss a few adjustments on our Discord server. It would be easier to communicate there. If that doesn't work for you, I can update your PR myself. Thanks!

No problem, I'm jack3580 in discord

samarmeena commented 3 months ago

Your PR is now ready. However, there are a few concerns we need to address before merging:

  1. I set up the plugins and enabled YouTube lyrics, but it consistently says "no response" even when lyrics are typically available on the video. I might not have configured it correctly, so it needs to be tested before merging.

  2. By default, I designed the plugin-lava-player to work with the YouTube plugin, as it's the most common use case. However, we can't add these features without providing a configuration option to disable them (lyrics slash command at least). This needs to be addressed before moving to production.

  3. Lavalink supports numerous other plugins, and we can't integrate them all without first addressing point 2. Users who utilize plugins beyond YouTube should implement their own solutions on top of the queue for these features, as the plugin-lava-player currently only supports the YouTube plugin.

Please review these concerns when you have time. Once resolved, we can proceed with the merge. Thank you.

However, if we cannot resolve them. We can move forward with merge, without adding this to plugin-lava-player