Closed ravener closed 3 months ago
@ravener can you send example of how it look before vs now. I just want to see, how it's look for end user. Thank you
Also run npm run fix:prettier
@ravener can you send example of how it look before vs now. I just want to see, how it's look for end user. Thank you
oh sorry, I just woke up and came from reading email title only. Just get the prettier done. Awesome change btw.
@ravener yeah, making errors and similar ephemeral true is good idea, I say go with it in another PR.
Also run
npm run fix:prettier
done, my bad I quickly used the github editor but moving forward i should stick to the tooling
@ravener there is relevant examples of rate limit. They are affected by this. Could you please address them as well.
Relative is good, but we cannot control it.
Relative is good, but we cannot control it.
yeah I figured it'd look a bit weird when the time expires (it starts showing 'ago') but thought that'd be a minor inconvenience and the benefits would still outweigh it. In my own bots I typically use relative dates but without discord's timestamps so they may not update in real time but they look better, especially for short cooldowns like 5 seconds.
@ravener there is relevant examples of rate limit. They are affected by this. Could you please address them as well.
The examples in the README look okay unless I'm missing something?
@ravener I am going to save your time, I will take over this PR (hope you don't mind).
I am implementing a new useful utility called TimeFormat
. I will use that in this PR. One of its function is TimeFormat.StaticRelativeTime
, so we can make that as a default time format. Or let me know, what do you think.
@ravener I am going to save your time, I will take over this PR (hope you don't mind).
I am implementing a new useful utility called
TimeFormat
. I will use that in this PR. One of its function isTimeFormat.StaticRelativeTime
, so we can make that as a default time format. Or let me know, what do you think.
Sounds good to me 👍, looking forward to it.
I think a much more user-friendly option is to use relative timestamps, it makes more sense to say you can use the command in 5 seconds, or in 6 hours, instead of telling the user that you can use it at 6:42 PM.
On the other hand I'm not sure if this change is to be merged as is, it's meant to start a discussion:
until
still make any sense here after the change?{time}
or{duration}
and keep{until}
as is, this will preserve backward compatibility with existing code while giving an option to use this relative notation for those who desires it.Off topic but I would also propose for making the
ephemeral
option betrue
by default, it's one of the best features of slash commands and as slash commands are meant to reduce user mistakes it also makes sense to spit out rate limit errors and similar in an ephemeral reply rather than contributing to useless bot command spam, at least that's my opinion that all errors and embarrassing mistakes remain an ephemeral reply only sending the actual results to the world. Obviously I can just wrap the guard into a custom function and set it to true as the default for my own bot but I'd like to hear the possibility of it being the default here?