discordx-ts / discordx

🤖 Create a discord bot with TypeScript and Decorators!
https://discordx.js.org
Apache License 2.0
584 stars 50 forks source link

[Feature]: Update Lavalink to support V4 #999

Closed ElMehdiBouamama closed 1 month ago

ElMehdiBouamama commented 3 months ago

Feature?

Lavalink has recently updated their library to V4 while introducing breaking changes that made the music features in this repo outdated. With time i suspect that the previous Lavalink V3.7 is not gonna be maintained and will probably cause breaking changes in this code base. I suggest to migrate the code base to a V4.0 preemptively before a shortage happens (which most surely is gonna happen in the future) Here is a link to the new V4 Lavalink Release: https://github.com/lavalink-devs/Lavalink/releases/tag/4.0.4

Package

@discordx/lava-player

ElMehdiBouamama commented 1 month ago

Any news on this issue or should we swap out of the library?

samarmeena commented 1 month ago

Hi,

The reason this issue remains open is that I plan to address it soon. However, I've been busy since it was first reported. If anyone else can submit a pull request in the meantime, it would be appreciated. Otherwise, I will update you through this issue once it’s resolved. Thank you!

ElMehdiBouamama commented 1 month ago

I will try to make a pull request with the adequate changes. I was about to migrate to a new library, but if this is still active, i can contribute.

samarmeena commented 1 month ago

@ElMehdiBouamama just wanted to ask, are you familiar with changes or if you have tried them?

ElMehdiBouamama commented 1 month ago

I haven't tried the changes yet, but i will experiment with it and get familiar.

samarmeena commented 1 month ago

I am doing some testings, you can connect with me in our discordx server.

samarmeena commented 1 month ago

@ElMehdiBouamama Lavalink v4 support has been released. If you are using our plugin, it will be updated shortly. Thank you for reminding me about this upgrade; it was indeed necessary.