search

discosultan / VulkanCore

Vulkan 1.0 graphics and compute API bindings for .NET Standard
MIT License
168 stars 27 forks source link

Add net standard 2.0 target in addition to net standard 1.3 #28

Closed amerkoleci closed 6 years ago

amerkoleci commented 6 years ago

Fixes/Extendes #15

WardBenjamin commented 6 years ago

Like I said on the issue, we don't need this - we're not using any of these features and a netstandard2.0 class library, or a recent .NET Framework or .NET Core version can all reference the older netstandard1.3 binary with no problems.

amerkoleci commented 6 years ago

I agree, still it doesn't hurt to have the net standard 2.0, similar as https://github.com/JamesNK/Newtonsoft.Json/blob/master/Src/Newtonsoft.Json/Newtonsoft.Json.csproj

discosultan commented 6 years ago

I'd need to understand what benefit would targeting netstandard2.0 add before moving forward with this.

Also, with netstandard2.0 target we wouldn't need to reference all the packages that are referenced in netstandard1.3. An example being System.ValueTuple. This might require conditional targeting in project file.

amerkoleci commented 6 years ago

No, you have both target supported

discosultan commented 6 years ago

Yeah, that's why I mentioned conditional package referencing. So we would reference System.ValueTuple when compiled for netstandard1.3 target, but not when compiled for netstandard2.0.

amerkoleci commented 6 years ago

We can add ItemGroup with condition reference for System.ValueType