search

discosultan / penumbra

2D lighting with soft shadows for MonoGame
MIT License
315 stars 32 forks source link

Support for MonoGame 3.7.1 #21

Closed fr0 closed 5 years ago

fr0 commented 5 years ago

I upgraded my project from MonoGame 3.6 to MonoGame 3.7.1, and now I'm getting these errors:

.../penumbra_hull.fx: ...\\penumbra_hull.fx(4,32-33): error X3530: invalid register specification, expected 'b' binding
...\\penumbra_hull.fx(9,31-32): error X3530: invalid register specification, expected 'b' binding

(similar errors in the other fx files).

ddruganov commented 5 years ago

simple solution: go to each specified line in the error log and change the register letter to 'b' example: cbuffer cbPerGrame : register(c1) will become cbuffer cbPerGrame : register(b1) and so on

discosultan commented 5 years ago

Thanks for reporting! I will test with latest MonoGame soon.

discosultan commented 5 years ago

Made the following changes to fix for MG 3.7:

Can someone confirm if that solves it for em? I will then publish new nugets.

Related issue: https://github.com/discosultan/penumbra/issues/22

ddruganov commented 5 years ago

Can confirm that removing HLSL register specifications solved the issue of invalid register naming

discosultan commented 5 years ago

Thanks @SamTheT! I've published new nugets. If the issue persist, feel free to reopen.