discourse / logster

Log viewer UI and framework for rack
MIT License
629 stars 52 forks source link

DEV: Fix flaky test seen on CI #236

Closed tgxworld closed 3 months ago

tgxworld commented 3 months ago

Error seen on CI:

Error:
TestRedisStore#test_solving_with_some_missing_version:
NameError: uninitialized constant Logster::RedisStore::Set
    lib/logster/redis_store.rb:396:in `clear_solved'
    lib/logster/redis_store.rb:99:in `solve'
    test/logster/test_redis_store.rb:742:in `test_solving_with_some_missing_version'
tgxworld commented 3 months ago
Error:
TestRedisStore#test_solving_with_some_missing_version:
NameError: uninitialized constant Set
    lib/logster/redis_store.rb:396:in `clear_solved'
    lib/logster/redis_store.rb:99:in `solve'
    test/logster/test_redis_store.rb:742:in `test_solving_with_some_missing_version'

Hmm this is strange... the issue is not what I thought it was... got to dig further.