search

discourse / mini_mime

minimal mime type library
MIT License
95 stars 34 forks source link

Version bump #53

Closed SamSaffron closed 1 year ago

casperisfine commented 1 year ago

I don't know if you are aware but neither 1.1.3 nor 1.1.4 were pushed to rubygems: https://rubygems.org/gems/mini_mime

SamSaffron commented 1 year ago

yikes I was just about to push it @casperisfine but it looks like tests are failing on main...

casperisfine commented 1 year ago

👀

casperisfine commented 1 year ago

I can repro after updating mime-types.

casperisfine commented 1 year ago 
  1) Failure:
MiniMimeTest#test_full_parity_with_mime_types [/Users/byroot/src/github.com/casperisfine/mini_mime/test/mini_mime_test.rb:139]:
Expected ".ggs" to return "application/vnd.geogebra.slides", got: nil
Expected ".cjs" to return "text/javascript", got: nil
casperisfine commented 1 year ago

Caused by https://github.com/mime-types/mime-types-data/commit/02786577194203a143e421354ee74a4a53e568cb

Not sure what is best here, I can easily ignore these in the test.