search

discourse / prometheus_exporter

A framework for collecting and aggregating prometheus metrics
MIT License
537 stars 155 forks source link

allow specification of exporter bind address #101

Closed and0x000 closed 4 years ago

and0x000 commented 4 years ago

I think it would be a good idea, to allow the specification of an address to which PrometheusExporter::WebServer should bind to.

See WEBrick::HTTPServer -> :BindAddress

Going a step further, binding to localhost only should probably become the default behavior. This is the way, several other pieces of software do it to avoid unintended insecure configurations.

SamSaffron commented 4 years ago

I am fine for starters for this to be configurable and documented, care to post a PR?