Add support for HTTPAuth::BasicAuth in prometheus_exporter

discourse / prometheus_exporter

A framework for collecting and aggregating prometheus metrics

MIT License

532 stars 154 forks source link

Closed dyoung522 closed 3 years ago

dyoung522 commented 3 years ago

Adds support for basic authentication in the prometheus_exporter CLI application.

When given a htpasswd filename via the --auth command line argument, the server will use this file to authenticate any requests to the /metrics endpoint.
Optionally, a custom REALM may be provided via the --realm argument. The default REALM is "Prometheus Exporter"

Note: the htpasswd file must be created beforehand and, due to limitations in WEBrick, only crypt is supported.

SamSaffron commented 3 years ago

A very nice PR! thank you. I love that you cleaned up stuff as you went.

I think the only big missing thing here is documentation in the README, can you add that?

SamSaffron commented 3 years ago

Thanks! failure looks unrelated, change looks good to me! thanks heaps.