discourse / prometheus_exporter

A framework for collecting and aggregating prometheus metrics
MIT License
525 stars 153 forks source link

FEATURE: add customizable labels option to puma collector (#172) #173

Closed codez closed 3 years ago

codez commented 3 years ago

As discussed in #172, a basic implementation to add customizable labels for the puma collector.

SamSaffron commented 3 years ago

One more tiny thing and we can merge.

Can you review the README and make sure it covers how to use this?

codez commented 3 years ago

I added a short note similar to other collectors.

SamSaffron commented 3 years ago

Oh I merged in the wrong order, can you rebase?

codez commented 3 years ago

There was no order, just changes in the same lines. I've rebased.

SamSaffron commented 3 years ago

cool! looks good!