FEATURE: SidekiqStats metrics

discourse / prometheus_exporter

A framework for collecting and aggregating prometheus metrics

MIT License

525 stars 153 forks source link

FEATURE: SidekiqStats metrics #194

Closed mrsimo closed 2 years ago

mrsimo commented 2 years ago

Hi again! Second PR today, sorry for the noise!

This is the last custom collector we have. I wasn't sure if it'd be as useful as the others, but we like having this information in Prometheus, so I thought it might be useful to others as well.

This collector just fetches Sidekiq::Stats and exposes the numbers. No labels or anything involved.

Thank you!

SamSaffron commented 2 years ago

Overall seems fine to me, only a few small comments.

SamSaffron commented 2 years ago

Yes, very much like your changes, thanks @mrsimo