search

discourse / prometheus_exporter

A framework for collecting and aggregating prometheus metrics
MIT License
525 stars 153 forks source link

feat(histogram): buckets #207

Closed kayn1 closed 2 years ago

kayn1 commented 2 years ago

What?

Allow to specify values for default buckets in histogram.

Why?

Would be good to have ability to specify your own values for buckets. There is a similar ability for labels.

SamSaffron commented 2 years ago

I think this is fine, do we have anything to educate users about this pattern in the readme? can you add that?

kayn1 commented 2 years ago

I think this is fine, do we have anything to educate users about this pattern in the readme? can you add that?

@SamSaffron Sure, I will add description and examples to the readme. 👍

Edit: Description and example have been added. @SamSaffron

kayn1 commented 2 years ago

@SamSaffron 🆙

SamSaffron commented 2 years ago

PR looks great to me! thanks @kayn1