search

discourse / prometheus_exporter

A framework for collecting and aggregating prometheus metrics
MIT License
532 stars 154 forks source link

Rename http_duration_seconds metric to http_request_duration_seconds #210

Closed MaximeD closed 2 years ago

MaximeD commented 2 years ago

Hello, Same thing as in #182 , we noticed that prometheus suggest to have http_request_duration_seconds instead of just http_duration_seconds.

Would you be open to this renaming, and bumping a new release with this breaking change?

Thank you!

SamSaffron commented 2 years ago

Yes, sounds like a good rename, but we are going to need to bump up the version.

MaximeD commented 2 years ago

Thanks, I'm looking forward for the new release!