Ability to choose style of instrumentation

discourse / prometheus_exporter

A framework for collecting and aggregating prometheus metrics

MIT License

525 stars 153 forks source link

Ability to choose style of instrumentation #228

Closed bcharna closed 2 years ago

bcharna commented 2 years ago

prometheus_exporter cannot reliably be used with other instrumentation libraries that use prepend to instrument methods as described in https://github.com/discourse/prometheus_exporter/issues/159. The goal of this PR is to provide the ability to have prometheus_exporter instrument using prepend, while still maintaining the default of alias_method.

SamSaffron commented 2 years ago

what a wonderful PR, well documented, well tested, thanks @bcharna !