FIX for ruby 3 incompatibility in sidekiq middleware, fixes #229

discourse / prometheus_exporter

A framework for collecting and aggregating prometheus metrics

MIT License

525 stars 153 forks source link

FIX for ruby 3 incompatibility in sidekiq middleware, fixes #229 #230

Closed benzimmer closed 2 years ago

benzimmer commented 2 years ago

See #229 for more details.

The test case might seem a bit weird, but I didn't find a more elegant way to reproduce Sidekiq's middleware initialization. So definitely open for suggestions.

Sidekiq middleware chain for reference: https://github.com/mperham/sidekiq/blob/main/lib/sidekiq/middleware/chain.rb

SamSaffron commented 2 years ago

@mperham what do you think of the workaround? I guess param handling changes between 2.7 / 2.8 / 3.0 are a bit of a sore point?

mperham commented 2 years ago

Lgtm!

SamSaffron commented 2 years ago

thanks @benzimmer !