FIX: correct instrumentation for Redis 5

[SamSaffron]

Redis 5 gem introduces redis_client as the low level transport method

We no longer patch Redis gem if we detect it is version 5 and above and instead use the supported middleware interface to patch it.

[SamSaffron]

@tgxworld / @byroot I think I have all the feedback addressed, let me know what you think

[SamSaffron]

Oh tricky one @byroot ... what happens if a pipeline takes say N seconds to commit and get results back from Redis, how is the instrumenter going to pick it up?

[byroot]

what happens if a pipeline takes say N seconds to commit and get results back from Redis, how is the instrumenter going to pick it up?

I'm not sure I understand what is tricky here.

module MyInstru
  def call_pipelined(commands, config)
    start = Time.now
    result = super
    duration = Time.now - start # N seconds
    results
  end
end

[SamSaffron]

Oh so individual commands are not instrumented, makes sense

On Fri, 28 Oct 2022 at 7:10 pm, Jean Boussier @.***> wrote:

what happens if a pipeline takes say N seconds to commit and get results back from Redis, how is the instrumenter going to pick it up?

I'm not sure I understand what is tricky here.

module MyInstru def call_pipelined(commands, config) start = Time.now result = super duration = Time.now - start # N seconds results endend

— Reply to this email directly, view it on GitHub https://github.com/discourse/prometheus_exporter/pull/250#issuecomment-1294658430, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABIXKUVLAX2MDSYEDUL43WFOC77ANCNFSM6AAAAAARPU2QY4 . You are receiving this because you authored the thread.Message ID: @.***>

[SamSaffron]

Awesome thanks about the tip !

On Fri, 28 Oct 2022 at 8:02 pm, Sam Saffron @.***> wrote:

Oh so individual commands are not instrumented, makes sense

On Fri, 28 Oct 2022 at 7:10 pm, Jean Boussier @.***> wrote:

what happens if a pipeline takes say N seconds to commit and get results back from Redis, how is the instrumenter going to pick it up?

I'm not sure I understand what is tricky here.

module MyInstru def call_pipelined(commands, config) start = Time.now result = super duration = Time.now - start # N seconds results endend

— Reply to this email directly, view it on GitHub https://github.com/discourse/prometheus_exporter/pull/250#issuecomment-1294658430, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABIXKUVLAX2MDSYEDUL43WFOC77ANCNFSM6AAAAAARPU2QY4 . You are receiving this because you authored the thread.Message ID: @.***>

[SamSaffron]

@tgxworld we are all done now, your comment is addressed