search

discourse / prometheus_exporter

A framework for collecting and aggregating prometheus metrics
MIT License
525 stars 153 forks source link

FIX: sidekiq stats collector memory leak #256

Closed mpucholblasco closed 1 year ago

mpucholblasco commented 1 year ago

We also experienced the problem explained in #240 , in which metrics present in the sidekiq stats collector started to grow and saturated the process (used all CPU assigned to it).

This PR aims to clean old metrics, as sidekiq_queue_collector.rb does.

SamSaffron commented 1 year ago

Oh ... nice catch, thanks for fixing!

SamSaffron commented 1 year ago

Let me know that this resolves the issue, once confirmed I will push out a release.

mpucholblasco commented 1 year ago

Let me know that this resolves the issue, once confirmed I will push out a release.

Hi @SamSaffron , thanks for the fast reply. Sure, gonna test it. I will notify to you with the results.

mpucholblasco commented 1 year ago

Hello @SamSaffron , after some tests, seems that the problem has been fixed, so I guess that you can push out a release.

Thanks!

SamSaffron commented 1 year ago

cool, will push a new release today, thanks!