Currently, PrometheusExporter::Metrics::Base.default_labels will overwrite the labels specified when observing metrics in the labels_text output. This isn't ideal in scenarios where you want to specify a label key/value pair that doesn't match the default labels.
In this pull request, I've swapped the ordering of the merge such that we merge the specified labels into the default labels, meaning the specified labels have precedence over the default ones.
SamSaffron
commented
2 years ago
Currently,
PrometheusExporter::Metrics::Base.default_labelswill overwrite the labels specified when observing metrics in thelabels_textoutput. This isn't ideal in scenarios where you want to specify a label key/value pair that doesn't match the default labels.In this pull request, I've swapped the ordering of the merge such that we merge the specified labels into the default labels, meaning the specified labels have precedence over the default ones.