discourse / prometheus_exporter

A framework for collecting and aggregating prometheus metrics
MIT License
525 stars 153 forks source link

Delayed Job metric name prefixes differ from each other #291

Open NickLarsenNZ opened 10 months ago

NickLarsenNZ commented 10 months ago

The patterns I have noticed so far are:

image

I think these should all be delayed_job_ (without the s), then followed by the metrics specifics (eg: total, or failed_total, etc...)

NickLarsenNZ commented 10 months ago

Maybe the first two are fine as is (jobs for aggregate, and job for per-job stats).

Sidekiq has the same:

image

But then perhaps for delayed-job it should be more like:

Although it is redundant, the tool is called "delayed job", and there are jobs and per-job metrics.