search

discourse / prometheus_exporter

A framework for collecting and aggregating prometheus metrics
MIT License
525 stars 153 forks source link

Fallback to detect controller and action as symbols #316

Open dlanderson opened 1 month ago

dlanderson commented 1 month ago

In our Rails 7.1.3.2 app, action_dispatch.request.parameters is a hash with symbols. This adds a fallback to detect the action and controller names if they are symbols.

SamSaffron commented 1 month ago

would be awesome if we could add a test here to catch this? especially if it was a general test that would work on any version and catch this in a side effect.