search

discoverygarden / dgi_fixity

Perform periodic fixity checks on selected files.
GNU General Public License v2.0
1 stars 5 forks source link

[DGI9-522] Allow FixityCheckBatchCheck to advance to the next batch #19

Closed seth-shaw-asu closed 2 months ago

seth-shaw-asu commented 3 months ago

The "remaining" sandbox property was simply set to the count of all periodic checks which was caused $progress_halted to always return True which set the "finished" property at the end of the first batch.

This PR renames 'remaining' to 'count' to more accurately reflect what it represents and removes the erroneous end condition.

Resolves #16 and replaces #18, which didn't work when I tested it.

ruebot commented 3 months ago

Tested, and can confirm it resolves #16.

JojoVes commented 3 months ago

I just added the jira ticket ID to the PR title so this gets linked to internal dgi ticket tracking stuff. As I commented in https://github.com/discoverygarden/dgi_fixity/pull/18#issuecomment-2059271049, I think this solution is a good fix. I'm moving our internal ticket from Peer Review to QA.

chrismacdonaldw commented 2 months ago

Linter is catching some alphabetical imports issues, but they're not directly correlated to this work. I'm moving this forward and merging.