Do not remove name from suggestions as soon as it is typed fully

discoveryjs / discovery

A framework for rapid data (JSON) analysis, shareable serverless reports and dashboards

https://discoveryjs.github.io/discovery/

MIT License

336 stars 6 forks source link

Do not remove name from suggestions as soon as it is typed fully #37

Open rualark opened 4 years ago

rualark commented 4 years ago

If name is removed, typing full name and pressing Enter selects another name

lahmatiy commented 4 years ago

If we don't remove a variant, so enter will have no effect and suggestion popup will be with no changes like something broken. Not sure that's better than current behaviour.

rualark commented 4 years ago

Enter should always close suggestion popup - this is a visual effect. Example: I have two fields, 'filter' and 'filter_id'

Current behavior:

After typing 'filter', 'filter' is removed from suggestions and then pressing Enter inputs 'filter_id'

Desired behavior:

After typing 'filter', 'filter' is not removed from suggestions and then pressing Enter inputs 'filter'

Example in vscode: