search

discreteoptimization / assignment

Assignments and Graders for Discrete Optimization on Coursera
https://www.coursera.org/learn/discrete-optimization
MIT License
95 stars 81 forks source link

Solver java fixed #33

Closed luckman closed 7 years ago

luckman commented 7 years ago
  1. Universal new lines (see https://www.coursera.org/learn/discrete-optimization/discussions/all/threads/qsGQMI_FEeaEMQ4qyS4RFQ)
  2. print command fixed
codecov-io commented 7 years ago

Codecov Report

Merging #33 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   89.48%   89.48%           
=======================================
  Files          17       17           
  Lines        1056     1056           
=======================================
  Hits          945      945           
  Misses        111      111

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9bf50cd...6c1047d. Read the comment docs.

ccoffrin commented 7 years ago

Looks good. Thanks!

Out of curiosity, on which platform was there an issue that universal_newlines fixed?

luckman commented 7 years ago

I faced an issue with default java solver on my Windows 7 64-bit

Java stdout was String 18 0 1 1 0 0

(or "18 0\n1 1 0 0")

Result of the scripts looks like b'18 0\r\n1 1 0 0'

ccoffrin commented 7 years ago

k, thanks!