discuitnet / discuit

A free and open-source community discussion platform.
https://discuit.net
GNU Affero General Public License v3.0
384 stars 40 forks source link

Improvements for lists #100

Closed ttaylor-st closed 3 weeks ago

ttaylor-st commented 3 weeks ago

Addresses most things in #90 (creating lists from the lists page, removing items from a list without the additional steps), makes the /{user}/lists page responsive and also removes the visibility filter if the user doesn't own the list.

Something to note: Instead of providing a link to a user's lists page, I added a card with a list of all the user's lists in the About section

To do:

previnder commented 3 weeks ago

Looks good. Thanks. I was wondering where to add a link to the lists page on the user profile page, but showing all the user's lists in the sidebar there instead is probably a better idea. Perhaps we could add a link to the lists page as a last item in the lists list here:

lists

noClaps commented 3 weeks ago

You could make the header of that section the link to the lists page.

previnder commented 3 weeks ago

That could also work. Or a "View all" button here:

lists2

ttaylor-st commented 3 weeks ago

Yeah, I think a button in the top right would be a bit clearer to the user

ttaylor-st commented 3 weeks ago

I believe this is all ready now!

previnder commented 3 weeks ago

I don't really see the need for the "Move to list" option in the drop-down. List items can already be moved from one list to another by unselecting the current list and selecting another in the SaveToList modal, which only requires one extra click compared to the "Move to list" option. While this functionality might not at first be obvious, if anyone spends a bit of time rearranging the items in their lists, it wouldn't take long for them to figure it out.

Other than that, yeah, I think this is ready.

ttaylor-st commented 3 weeks ago

That makes sense, it does seem a bit redundant now that I think about it.