search

discuitnet / discuit

A free and open-source community discussion platform.
https://discuit.net
GNU Affero General Public License v3.0
384 stars 40 forks source link

Fix: 404 when opening a Discuit image link from Discuit #103

Closed ttaylor-st closed 3 weeks ago

ttaylor-st commented 3 weeks ago

Fixes #102

All internal links were previously handled with Link, this PR adds an exception for internal links that begin with /images, which will now instead use a.

previnder commented 3 weeks ago

I think we should probably add a target="_blank" attribute to the new a tag. The reason being that if the image is opened in the same browser tab, then all the state of the React app would be lost when the user comes back to the website, and, most crucially, the back button would most likely be broken.

ttaylor-st commented 3 weeks ago

Done!