[BUG] Font issues - Githubissues

discuitnet / discuit

A free and open-source community discussion platform.

https://discuit.net

GNU Affero General Public License v3.0

384 stars 40 forks source link

[BUG] Font issues #110

Open noClaps opened 2 weeks ago

noClaps commented 2 weeks ago

I'll keep adding new comments as they come, but these should be extracted into their own issues and fixed.

previnder commented 2 weeks ago

[ ] Word breaking when it should be in a single line

Fixed in f31b1d52.

ttaylor-st commented 5 days ago

Font rendering incorrectly

I'm fairly certain this is caused by a regression in WebKit where it's not automatically setting the optical size. Should only affect Safari 16.0-16.4 on iOS + macOS

We could either:

modify Inter, to "remove the named instances with a non-default opsz." (source),
or explicitly state opsz in font-variation-settings for the affected versions

noClaps commented 4 days ago

I vote for stating opsz in our CSS. Maybe an issue can be opened in the Inter repo for this, but modifying Inter ourselves means we'll have to maintain that change through all future versions.

According to the WebKit bug report this seems to have been fixed last year. I'm not sure how much responsibility we should take to maintain compatibility with older versions of browsers. Safari 17 has been out for a while now, most people have probably updated to it.

ttaylor-st commented 3 days ago

Oh, looks like someone already made an issue in the Inter repo (https://github.com/rsms/inter/issues/589) but it was closed as not planned

I'll just go ahead and make a PR to add the workaround