search

discuitnet / discuit

A free and open-source community discussion platform.
https://discuit.net
GNU Affero General Public License v3.0
422 stars 50 forks source link

[Suggestion] Sort by all #133

Closed Kaamkiya closed 1 month ago

Kaamkiya commented 1 month ago

The current sort options don't include all, which is odd because it's built in already.

For example, https://discuit.net/?sort=all shows the most popular posts of all time, and https://discuit.net/?sort=year shows this year only.

I'd like to make a PR for this.

EDIT: Looking closer, there is already a line of code for this, but it's hidden. Why is that?

previnder commented 1 month ago

EDIT: Looking closer, there is already a line of code for this, but it's hidden. Why is that?

Because on the desktop view it makes the feed-sort-bar too long causing it to overflow, I removed the All option as a quick fix. At the time, that was totally fine, since Discuit was under a year old.

image

I think it's time to redesign this UI component. Perhaps a drop-down would be a better choice.

Kaamkiya commented 1 month ago

Ohhh, that makes sense. A dropdown would be good.

Kaamkiya commented 1 month ago

I'll start development on this.

previnder commented 1 month ago

Hey @Kaamkiya, I had to complete this as part of the feed compact mode add. Hope you don't mind.

Kaamkiya commented 3 weeks ago

That's alright. Thanks for implementing it :)