Closed Codycody31 closed 3 months ago
Everything works now, the only thing that could probably be added would be a way to auto-generate the environment variables based on the struct rather than manually defining them, example here. However, it could always be added in a future PR.
We could indeed use reflection for that, but I'm going to merge this one right now. But yeah that could be a future PR.
Changes
inject-config
to return a yaml file with the config containing env varsgenerate-yaml.js
to generate a new file calledui-config.yaml
which is not included in git.Purpose
This PR now adds support for using environment variables making it way easier to run discuit via docker.
Related Issues
Requests When Reviewing
I didn't know how the cmd in
main.go
should be so it is calledinject-config
but it's most definitely free to be changed to a better name, as the current one was just a test/general and the purpose has changed.