discuitnet / discuit

A free and open-source community discussion platform.
https://discuit.net
GNU Affero General Public License v3.0
384 stars 40 forks source link

Bookmarking posts and comments #73

Closed ttaylor-st closed 1 month ago

ttaylor-st commented 1 month ago

Closes #21.

So far, I've implemented the most important parts for the backend, but there's still some routes missing (updating lists), and some cleaning up to do, e.g., error handling in case of duplicate list names. Also just thought, we'll probably want a pagination for GET /api/bookmarks/{listID}/{itemID}, maybe GET /api/bookmarks/ as well?

Still TODO:

previnder commented 1 month ago

There's a bit of a conflict here: I've already half implemented Lists in discuitnet:lists a while ago. I've yet to attach the API endpoints and create the UI, but the core part supports pagination, sorting, and fetching the content along with the list items.

ttaylor-st commented 1 month ago

I haven't been able to find discuitnet:lists, probably just my eyes and brain not cooperating, is there anywhere specific I should be looking?

Codycody31 commented 1 month ago

@ttaylor-st I believe previnder is referring to this branch: https://github.com/discuitnet/discuit/tree/lists

ttaylor-st commented 1 month ago

Got it, thanks! @previnder what would you like me to do with this PR? I'd assume you'd like the work to happen on that branch

previnder commented 1 month ago

Bad timing, I guess, that we'd both decided to work on this feature at the same time. It's also partly my fault for not making a PR for the lists branch. Sorry about that.

The lists branch right now is mostly ready for merging. Only remains to attach the UI to the API and clean things up a bit.

@ttaylor-st, guess we'll close this PR and continue on in #77.

ttaylor-st commented 1 month ago

Okay, sounds good!