Closed ttaylor-st closed 1 month ago
There's a bit of a conflict here: I've already half implemented Lists in discuitnet:lists
a while ago. I've yet to attach the API endpoints and create the UI, but the core
part supports pagination, sorting, and fetching the content along with the list items.
I haven't been able to find discuitnet:lists
, probably just my eyes and brain not cooperating, is there anywhere specific I should be looking?
@ttaylor-st I believe previnder is referring to this branch: https://github.com/discuitnet/discuit/tree/lists
Got it, thanks! @previnder what would you like me to do with this PR? I'd assume you'd like the work to happen on that branch
Bad timing, I guess, that we'd both decided to work on this feature at the same time. It's also partly my fault for not making a PR for the lists
branch. Sorry about that.
The lists
branch right now is mostly ready for merging. Only remains to attach the UI to the API and clean things up a bit.
@ttaylor-st, guess we'll close this PR and continue on in #77.
Okay, sounds good!
Closes #21.
So far, I've implemented the most important parts for the backend, but there's still some routes missing (updating lists), and some cleaning up to do, e.g., error handling in case of duplicate list names. Also just thought, we'll probably want a pagination for
GET /api/bookmarks/{listID}/{itemID}
, maybeGET /api/bookmarks/
as well?Still TODO:
PUT /api/bookmarks/{listID}
/bookmarks
or/saved
page with a list of... lists :)/bookmarks/{listID}
or/saved/{listID}
page with the saved items in the specified list