disgoorg / disgo

A modular Golang Discord API Wrapper
Apache License 2.0
333 stars 37 forks source link

Change GuildPrivateThreadCreate to have NonInvitable field instead of Invitable #379

Closed myrkvi closed 2 months ago

myrkvi commented 2 months ago

The current implementation has the field Invitable and the JSON annotation omitempty, which results in the field being omitted when it is false. Not explicitly setting an invitable state should result in it being invitable, and as such, having NonInvitable achieves this.

topi314 commented 2 months ago

I'd rather have this be a pointer instead to be consistent with other fields & the discord docs

myrkvi commented 2 months ago

I'd rather have this be a pointer instead to be consistent with other fields & the discord docs

Definitely a saner way to do it :sweat_smile:

topi314 commented 2 months ago

sane is arguable in this case, getting pointers from primitives is annoying after all lol

topi314 commented 2 months ago

thanks