Closed exscriber closed 5 years ago
Hi, thanks for the patch. Couple of questions:
Thanks.
Ah yes I understand - didn't grok GCD at first, sorry.
Assume you mean num = 30000, den = 1001.
LGTM - @GregBakker ?
@GregBakker it’s about AVCodecContext deprecated. But without assigning timebase to both: codec and stream - av_write_header calculate messy codec_timebase on it’s own.
I like the std::gcd usage, new one to me :)
Thank you @exscriber for this contribution! :)
I revert f8187d0, because i was wrong with it. Current solution for issue #15 was tested on 1m15s files with different fps settings: https://www.dropbox.com/sh/4xki0t9vdsxjp46/AACGFpwL_0KXZoVd4Eoz3fkba?dl=0
Timebase of output files differ from Hap-QT, for example: Hap-CC 25fps: codec_time_base = 1/25, time_base=1/12800 Hap-QT 25fps: codec_time_base = 1/25, timebase=1/25
But muxer seems to calculate parameters right way: d3 and AE now read Hap-CC files without frame loss, show right fps and right duration.