search

disguise-one / hap-encoder-adobe-cc

Community-supported exporter of HAP codec family for Adobe CC applications
Other
169 stars 15 forks source link

Export with embeded audio #22

Closed exscriber closed 5 years ago

exscriber commented 5 years ago

Work in progress for #21 Summary of what done so far: all audio is rendered first, and we rely upon ffmpeg to buffer all the audio and write it out interleaved with the video frames

GregBakker commented 5 years ago

GOLD!

Would like people to try this branch ASAP; would like to get feedback prior to integrating to trunk on the associated issue.

A known trade-off with this PR is that the audio is rendered up-front and buffered, ahead of doing the video rendering. This avoids problems with fitting in with the multithreaded system interaction with MovieWriter, but introduces a short delay at the start of export.

This is a pretty minor issue with regard to getting audio export in - and we can probably address it subsequently by splitting up the file rendering into chunks.

GregBakker commented 5 years ago

LGTM