search

disguise-one / hap-encoder-adobe-cc

Community-supported exporter of HAP codec family for Adobe CC applications
Other
169 stars 15 forks source link

odd frame rates when exporting through Adobe 2018 and 2019 #31

Closed samkriemelmeyer closed 5 years ago

samkriemelmeyer commented 5 years ago

Hello!

have you ever seen odd HAP frame rates like 30.199 or 30.099 come from Adobe products? PC or Mac 2018 and 2019 seem do all do this.

compressor seems to do fine with it.

avf batch also does fine.

(codec v12)

cheers,

sam

GregBakker commented 5 years ago

Hi Sam,

I've found and fixed a problem like this with a prototype I'm working on (which supported import) - and it's possible there's an analog of it in the released version (round-tripping to adobe).

I'll look into this in the next few days.

Greg

samkriemelmeyer commented 5 years ago

Thank you Greg. It is a curious one. Gig is approaching fast... your help is appreciated.

GregBakker commented 5 years ago

It appears that the exported packet structures are correct presentation time-wise, but common tools (windows etc) calculate the frame-rate by (number of frames) / (sum of internal durations) - but at the moment the last frame duration is unset internally. So the framerate is calculated as (number of frames)/(duration excluding last frame), giving a slightly wrong framerate.

This may not be an issue in your case (or likely in most cases) as players most likely compute a timestamp, and then lookup the frame that should be showing at that time. So it's a display issue more than anything else.

I'll be making a build with a fix soonish anyway.

samkriemelmeyer commented 5 years ago

good detective work!

exscriber commented 5 years ago

Hi Sam,

Fix in 1.0.9 prerelease version cure odd framerates (it noted as 29.97 fix, but other affected as well). At least during my internal test runs - fps looks ok. Please take a look at 1.0.9, let us know if it works for you or not.

Nick

twhittock commented 5 years ago

Closing since no update - assuming 1.0.9 resolved the issue. Reopen if not. Thanks.