search

disk91 / helium-chirpstack-community

Glue between helium and chirpstack
20 stars 6 forks source link

fix: remove whitespace #87

Closed shawaj closed 10 months ago

shawaj commented 10 months ago

remove whitespace in toml files

disk91 commented 10 months ago

I love white spaces

shawaj commented 10 months ago

It's not removing blank lines, it is removing trailing whitespace at the end of lines and on empty lines.

That often tends to break stuff

disk91 commented 10 months ago

trailing whitespace are in comments and empty line in your proposal, if that break stuff, what no-one experienced yet, better to create an issue on Chirpsatck project to fix that as having spaces in configuration file is a normal situation.

shawaj commented 10 months ago

if that break stuff, what no-one experienced yet

Why do you think I opened the PR? Precisely because it did break stuff 🤦

Having trailing whitespace in configuration files isn't a "normal situation" and it does break stuff, regularly. Hence why every code linter in the world will throw an error on trailing whitespace, including on configuration files.

shawaj commented 10 months ago

Merged upstream now too... https://github.com/chirpstack/chirpstack/pull/308