disk91 / helium-chirpstack-community

Glue between helium and chirpstack
20 stars 6 forks source link

Update english translations - improved formatting and grammar #89

Closed DeflateAwning closed 8 months ago

DeflateAwning commented 8 months ago
disk91 commented 8 months ago

Thank you so much for this contribution. I won't merge it as it is because of the technical tag name modification that will create trouble in future merge from the different branches when not impacting the behavior.

I can propose two ways:

DeflateAwning commented 8 months ago

Thanks for reviewing it! Sure, I can re-work it a bit.

Can we please implement the changes of the "keys" for the translations though. Any translation for a call-to-action/button should have _button in its name, so that translators know that it is an action.

Also, signup_pmessage_3 is a less-good name than check_email_spam_message.

How can we make these changes so that they won't "create trouble in the future".

As far as I can tell, there is no one else with pending changes/branches (looking at Forks, and looking at the branches in this repo). If any owners of websites made changes and then didn't publish them back to the community, then that'll be on them to deal with any merge conficts (but again, I don't think there will be many/any; they were all very straight-forward renames). I was very miticulous to catch every instance.

disk91 commented 8 months ago

Thanks for reviewing it! Sure, I can re-work it a bit.

Can we please implement the changes of the "keys" for the translations though. Any translation for a call-to-action/button should have _button in its name, so that translators know that it is an action.

Also, signup_pmessage_3 is a less-good name than check_email_spam_message.

I'm not sure it's a really important thing but I can later work on this, it's improving code quality.

How can we make these changes so that they won't "create trouble in the future".

As far as I can tell, there is no one else with pending changes/branches (looking at Forks, and looking at the branches in this repo). If any owners of websites made changes and then didn't publish them back to the community, then that'll be on them to deal with any merge conficts (but again, I don't think there will be many/any; they were all very straight-forward renames). I was very miticulous to catch every instance.

All the code you get on the community branch is now coming from a private instance I maintain. So basically it makes conflict with me. Language file is easy merge, plenty of little non functional little modification will be more complicated. This is why it will be better for me to incorporate this from the master and publish it into community later on.

DeflateAwning commented 8 months ago

This feels like a quirky way to handle a public-facing open source project, but I can deal with that.

Might be best if you handle the merging! Let me know if you need any help!

disk91 commented 8 months ago

Most of the translations have been merged in en.json file.