search

disk91 / helium-chirpstack-community

Glue between helium and chirpstack
20 stars 6 forks source link

Re-apply missed translations from #90 #95

Closed DeflateAwning closed 8 months ago

DeflateAwning commented 8 months ago

If you disagree with any of the changes here, please start a code review and comment on the specific changes you disagree with. We can discuss, and I will revert them in this branch if you disagree with them. This is how git/GitHub PRs are intended to be used. Please merge this PR into main instead of trying to re-apply the changes some other way.

The way that you're applying my PRs (e.g., #90) is not working, as you keep missing my edits. I intend for all changes in this PR to be applied to upstream (this repo).

This is my third time that I've requested that many of these specific changes be made in the translations.

disk91 commented 8 months ago

Just the "Chirpstack" to "chirpstack", I use to have a capital and it has it in the other sentences as it's a "name"; For the rest it's great. Waiting for the change to merge it directly.

DeflateAwning commented 8 months ago

Good catch! Fixed everywhere!

disk91 commented 8 months ago

Pull request merged. Thank you for the contribution

DeflateAwning commented 8 months ago

Thank you!