search

diskfs / go-diskfs

MIT License
515 stars 113 forks source link

partition: add repair capabilities to GPT #187

Closed adamqqqplay closed 1 year ago

adamqqqplay commented 1 year ago

Based on #112, and addressing review comments. Thanks to the original author! @thebsdbox

  1. add Repair and Verify interfaces in type table
  2. add test to test opening the GPT image
deitch commented 1 year ago

@thebsdbox is great, isn't he? Did he do work elsewhere that you are moving in here?

adamqqqplay commented 1 year ago

@deitch Thanks for your review!

I just discovered a new improvement point. Maybe we could merge this two function in the future: tableFromBytes and tableHeaderFromBytes.

deitch commented 1 year ago

If it is easier, sure. These are private functions, so no worry about impact other than where they exist, and ability to read clearly.

thebsdbox commented 1 year ago

Apologies, I was always meant to circle back and finish this off :-(